-
Notifications
You must be signed in to change notification settings - Fork 597
Add provisional GEPs back to TOC #4145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rikatz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @kflynn As you wish :) |
/lgtm Thanks @rikatz! I think this is really important as we start looking to have things start in Provisional in order to make it into Experimental. |
/hold I was actually one of the people that argued for the removal of provisional from navigation. This was for a few reasons:
If we want to include provisional GEPs somewhere on the website, filled with lots of disclaimers about what it means for something to be provisional, I can be OK with that, I'd just rather have it somewhere less prominent and with more warnings about the nature of provisional proposals. |
Sorry @robscott, I remember seeing your comments on this now and spaced on it. 🤦♂️ Any suggestions on what you think would be reasonable for the presentation? If we’re having provisional be an important part of the release cycle, we need to have them visible somehow. |
(Maybe we should drop the TOC in the sidebar, and instead have links to category pages that then list the individual GEPs. 🤔) |
I can rework this PR to follow this approach instead, rendering the pages experimental, provisional, etc with the GEPs. Will take me some time tho :) |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Adds Provisional GEPs back to Website navigation
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: